Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX]: Pipeline failure since 2023-12-29 - JORAM PDF formatting issues #58

Merged
merged 3 commits into from
Jan 4, 2024

Conversation

HarryVasanth
Copy link
Collaborator

@HarryVasanth HarryVasanth commented Jan 3, 2024

Related issues

Closes #59

What does this PR do?

This PR fixes the issue where the current pipeline is failing due to the formatting issues with latest PDF by JORAM

Solution Overview

  • Add more robust matching
  • Add additional debug outputs
  • Add a debug fall-back URL from 2023 (for future refs)

Implementation Details

Matching & Catching

Debugging

⚠️ Warning:

The following alterations have to be done immediately after the first instance of the JORAM website publishes the page for the year 2024 (Link):

# JORAM link 2023 - For Debugging
- JORAM_LINK = "https://joram.madeira.gov.pt/joram/2serie/Ano%20de%202023"
- JORAM_PDF_LINK = "https://joram.madeira.gov.pt/joram/2serie/Ano%20de%202023/{file}"
+ #JORAM_LINK = "https://joram.madeira.gov.pt/joram/2serie/Ano%20de%202023"
+ #JORAM_PDF_LINK = "https://joram.madeira.gov.pt/joram/2serie/Ano%20de%202023/{file}"

# JORAM link
- #JORAM_LINK = "https://joram.madeira.gov.pt/joram/2serie/Ano%20de%20{date:%Y}"
- #JORAM_PDF_LINK = "https://joram.madeira.gov.pt/joram/2serie/Ano%20de%20{date:%Y}/{file}"
+ JORAM_LINK = "https://joram.madeira.gov.pt/joram/2serie/Ano%20de%20{date:%Y}"
+ JORAM_PDF_LINK = "https://joram.madeira.gov.pt/joram/2serie/Ano%20de%20{date:%Y}/{file}"

@HarryVasanth HarryVasanth added 🐛 bug Something isn't working 🪄 enhancement New feature or enhancement labels Jan 3, 2024
@HarryVasanth HarryVasanth self-assigned this Jan 3, 2024
@HarryVasanth HarryVasanth marked this pull request as ready for review January 3, 2024 00:44
@HarryVasanth HarryVasanth changed the title Fix JORAM formatting issues [FIX]: Pipeline Failure since 2023-12-29 - JORAM PDF formatting issues Jan 3, 2024
@HarryVasanth HarryVasanth changed the title [FIX]: Pipeline Failure since 2023-12-29 - JORAM PDF formatting issues [FIX]: Pipeline failure since 2023-12-29 - JORAM PDF formatting issues Jan 3, 2024
Copy link
Collaborator

@Dntfreitas Dntfreitas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :D

@HarryVasanth HarryVasanth merged commit 16defb4 into main Jan 4, 2024
@HarryVasanth HarryVasanth deleted the fix/joram-pdf-issue-00 branch January 4, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🪄 enhancement New feature or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Pipeline Failure since 2023-12-29
2 participants