Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust tox dependencies. #1218

Merged
merged 2 commits into from
May 14, 2020
Merged

Adjust tox dependencies. #1218

merged 2 commits into from
May 14, 2020

Conversation

carltongibson
Copy link
Owner

Curious CI failure after eca2c1f.

Experimenting, it doesn't seem markdown needs pinning any more.

@carltongibson carltongibson changed the title Unpin markdown. Adjust tox dependencies. May 14, 2020
@carltongibson
Copy link
Owner Author

It's the 3.1a1 alpha getting installed where we're expecting 3.0.

@carltongibson
Copy link
Owner Author

Plus the flake8 update added E741 ambiguous variable name

@codecov-io
Copy link

codecov-io commented May 14, 2020

Codecov Report

Merging #1218 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1218   +/-   ##
=======================================
  Coverage   99.43%   99.44%           
=======================================
  Files          15       15           
  Lines        1235     1255   +20     
=======================================
+ Hits         1228     1248   +20     
  Misses          7        7           
Impacted Files Coverage Δ
django_filters/filters.py 100.00% <100.00%> (ø)
django_filters/filterset.py 100.00% <0.00%> (ø)
django_filters/rest_framework/backends.py 100.00% <0.00%> (ø)
django_filters/rest_framework/filterset.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eca2c1f...44362e3. Read the comment docs.

@carltongibson carltongibson merged commit 1ebb03a into master May 14, 2020
@carltongibson carltongibson deleted the unpin-markdown branch May 14, 2020 14:49
@rpkilby rpkilby mentioned this pull request May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants