Fix template packaging #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be ready. |
rpkilby
commented
Dec 6, 2016
| @@ -34,11 +34,7 @@ | |||
| maintainer_email='carlton.gibson@noumenal.es', | |||
| url='http://github.com/carltongibson/django-filter/tree/master', | |||
| packages=find_packages(exclude=['tests']), | |||
| package_data={ | |||
There was a problem hiding this comment.
btw - my understanding is that package_data isn't necessary, given the use of a manifest and the include_package_data param.
charettes
approved these changes
Dec 9, 2016
rpkilby
force-pushed
the
fix-multi-template
branch
from
405e925
to
f6b8ff1
Compare
SJasoria
added a commit
to SJasoria/treeherder
that referenced
this pull request
Jun 19, 2017
The jobdetail browsable API pages were returning HTTP 500 since as of carltongibson/django-filter#580 it's necessary to add django-filter to INSTALLED_APPS: https://django-filter.readthedocs.io/en/latest/guide/install.html
edmorley
pushed a commit
to mozilla/treeherder
that referenced
this pull request
Jun 19, 2017
The jobdetail browsable API pages were returning HTTP 500 since as of carltongibson/django-filter#580 it's necessary to add django-filter to INSTALLED_APPS: https://django-filter.readthedocs.io/en/latest/guide/install.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting work on #578.