Bug 1372640 - Add django-filters to INSTALLED_APPS #2575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
suggested changes
Jun 19, 2017
There was a problem hiding this comment.
Many thanks for the PR!
Could you update the commit message to:
- Describe what was changed rather than a symptom of the bug (if you haven't seen it before https://chris.beams.io/posts/git-commit/ is a good read)
- In the multi-line part of the commit message, reference the Django filters installation guide and why this change is necessary
So perhaps something like:
Bug 1372640 - Add django-filters to INSTALLED_APPS
The jobdetail browsable API pages were returning HTTP 500 since as of
carltongibson/django-filter#580 it's necessary to add django-filter to
INSTALLED_APPS:
https://django-filter.readthedocs.io/en/latest/guide/install.html
Many thanks!
treeherder/config/settings.py
Outdated
| @@ -153,6 +153,7 @@ def server_supports_tls(url): | |||
| 'treeherder.autoclassify', | |||
| 'treeherder.credentials', | |||
| 'treeherder.seta', | |||
| 'django_filters' | |||
There was a problem hiding this comment.
I'd put this above the Treeherder entries and below the other custom Django packages (eg perhaps between corsheaders and graphene_django). Also in Python trailing commas are allowed in dicts/lists/... and are often preferred, since it reduces churn when adding an extra line to the end :-)
SJasoria
changed the title
The jobdetail browsable API pages were returning HTTP 500 since as of carltongibson/django-filter#580 it's necessary to add django-filter to INSTALLED_APPS: https://django-filter.readthedocs.io/en/latest/guide/install.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.