-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use docker for testing #631
Conversation
There is at least one extra env here ( |
Main issue is pip caching. Should be able to resolve that with a mount. |
… attempt to prime pip cache.
It looks like this will remain slower (at least for now): 3f6fb0b tries installing the requirements at the Cf Build 1073 and Build 1066 I'm guessing the bottom line is that Docker (or the host VM) is underpowered — particularly with regard to parallelisation — compared to the travis' own containers. (Just guessing.) Also there's a spurious error on the
I'll keep playing with this but it's not going to go in just yet. |
@rpkilby I see you contributed to |
It turns out that "Yes" is the answer there. #651 |
Yep - I started to submit a PR, but was hesitant since I was duplicating the build matrix in both tox and travis. That would be similar to DRF's tox config right now. I hand't thought to use tox-travis to just run all of the python version specific builds. |
For me the prime concern is keeping the matrix in one place. |
Yeah - the duplication isn't as bad, but it's still annoying to figure out what to correctly include/exclude in the travis matrix. Your approach is a good compromise |
Having played with Travis for Python 3.6 support, and not wanting to duplicate the tox config if possible, I thought to try using a preconfigured image with docker.
Not sure whether to merge this. A little slow-down would OK — I really don't want to duplicate the build matrix — that is a pain — but it would be nice to do better that 2x
tox
build anddetox
build? (cp 1065 vs 1066 — diff of 2s)