Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update States of Brazil - removing Fernando de Noronha #256

Merged
merged 1 commit into from
Mar 30, 2018
Merged

Update States of Brazil - removing Fernando de Noronha #256

merged 1 commit into from
Mar 30, 2018

Conversation

guicruzzs
Copy link

:) 🇧🇷

@guicruzzs guicruzzs force-pushed the master branch 2 times, most recently from a106cae to e72674b Compare March 30, 2018 13:52
@guicruzzs guicruzzs mentioned this pull request Mar 30, 2018
Closed
@swcraig
Copy link
Collaborator

swcraig commented Mar 30, 2018

Hi @guicruzzs,

Thank you for the contribution, and thank you for adding a CHANGELOG entry!
The links to sourcing the correctness of your PR are much appreciated; the data change itself looks correct.

The iso_data/base and locale/base directories should be left untouched. They are updated by an automated script. Modifications to the data should be done in the iso_data/overlay and locale/overlay directories.

The wiki has an example/direction on disabling (removing) a subregion from a country.

If you could disable the region in the iso_data/overlay/world/br.yml file (which you will need to create), that would be great and then we can merge! If you have any questions about this, please let me know.

@guicruzzs
Copy link
Author

Hello, @swcraig!!
Ok!
I'll make the changes 👍

@guicruzzs
Copy link
Author

Hello, @swcraig!!

Done!
I think now it's ok!
😄

@swcraig
Copy link
Collaborator

swcraig commented Mar 30, 2018

Fantastic, thank you for doing that so quickly.

swcraig
swcraig approved these changes Mar 30, 2018
View reviewed changes
Copy link
Collaborator

@swcraig swcraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇧🇷

@swcraig swcraig merged commit 62e9415 into carmen-ruby:master Mar 30, 2018
@guicruzzs
Copy link
Author

It's always a pleasure to help 🇧🇷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swcraig swcraig swcraig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guicruzzs @swcraig