Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Add default command-line parameter "-f" for Jupyter Notebooks #275

Merged
merged 7 commits into from
Jul 3, 2022

Conversation

carnisj
Copy link
Owner

@carnisj carnisj commented Jul 3, 2022

Add a "-f" command line parameter to host the automatically generated parameter in Jupyter notebooks (kernel json file path). It was conflicting with the "--flip_reconstruction" parameter.

Fixes #230

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have made corresponding changes to the documentation
  • I have run doit and all tasks have passed

@carnisj carnisj marked this pull request as draft July 3, 2022 06:42
@carnisj
Copy link
Owner Author

carnisj commented Jul 3, 2022

The issue seems to be with the command line parameters overriding the correctly parsed argument from the YAML file. There seems to be a hidden parameter -f reserved for the location of the kernel json file.

@carnisj carnisj marked this pull request as ready for review July 3, 2022 08:11
@carnisj carnisj changed the title [Bug]: Rename the parameter 'flip_reconstruction' to 'flip_crystal' [Bug]: Add default command-line parameter "-f" for Jupyter Notebooks Jul 3, 2022
Copy link
Collaborator

@DSimonne DSimonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I don't remember how we had gotten it to work until now ?
Because I do not have the error anymore ...

@carnisj
Copy link
Owner Author

carnisj commented Jul 3, 2022

For the GUI, we removed the part related to command-line parameters, therefore the config file parameters are not overriden anymore.

@carnisj carnisj merged commit e0a9b39 into main Jul 3, 2022
@carnisj carnisj deleted the flip branch July 3, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Arguments not parsed properly when using the GUI
2 participants