LPS-122028 create unit tests #236

marcosapmf · 2020-10-21T12:37:29Z

Related Issue: https://issues.liferay.com/browse/LPS-122028

liferay-forms · 2020-10-21T12:37:30Z

Hi, you don’t need to run the CI commands anymore, I’ll do it for you and let you know if any issue happens.

liferay-forms · 2020-10-21T12:37:30Z

ci:test:sf

liferay-continuous-integration · 2020-10-21T12:37:36Z

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

liferay-continuous-integration · 2020-10-21T12:43:38Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: e035cc567da2b8aba5f511714e052127ef347634

Sender Branch:

Branch Name: LPS-122028
Branch GIT ID: 5db2bd89c1512991eeba95d33739c869594b5fee

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-forms · 2020-10-21T12:43:39Z

ci:test:relevant

carolmariaabb · 2020-10-21T12:45:05Z

Just started reviewing :)

Sent from GH.

liferay-continuous-integration · 2020-10-21T12:45:41Z

Jenkins Build:test-portal-source-format#4973
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:carolmariaabb#236
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:sf
Spira Release Build:master - marcosapmf > carolmariaabb - PR#236 - 2020-10-21[05:39:37]
Spira Jenkins Build:publish-spira-report#9903

carolmariaabb · 2020-10-21T12:59:50Z

Just started reviewing :)

Sent from GH.

...pping-form-builder/src/main/resources/META-INF/resources/js/components/Sidebar/Sidebar.es.js

liferay-continuous-integration · 2020-10-21T15:00:17Z

✔️ ci:test:stable - 14 out of 14 jobs passed

❌ ci:test:relevant - 114 out of 119 jobs passed in 2 hours 9 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: e035cc567da2b8aba5f511714e052127ef347634

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 27bc57847a0fbdd19ff9c855a0e2eda43d622c23

ci:test:stable - 14 out of 14 jobs PASSED

14 Successful Jobs:

ci:test:relevant - 114 out of 119 jobs PASSED

5 Failed Jobs:

114 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/2
Job Results:
1 Test Passed.
1 Test Failed.
1. AXIS_VARIABLE=0,label_exp=!master #365681
  1. LocalFile.FormsDataProvider#ConfigureAutocompleteWithTextField - Poshi Report - Poshi Summary - Console Output
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/61
Job Results:
1 Test Passed.
1 Test Failed.
1. AXIS_VARIABLE=0,label_exp=!master #414534
  1. LocalFile.Forms#SubmitFormWithAllFieldTypesAndThreePages - Poshi Report - Poshi Summary - Console Output
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/65
Job Results:
1 Test Passed.
1 Test Failed.
1. AXIS_VARIABLE=0,label_exp=!master #365686
  1. LocalFile.Forms#EditTranslatedGridField - Poshi Report - Poshi Summary - Console Output

Failures in common with acceptance upstream results at 4474e93:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8

Job Results:

1160 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=2,label_exp=!master #317788

PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError: 
HikariPool-1 - Connection is not available, request timed out after 600000ms.
	at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
	at java.nio.file.Files.walkFileTree(Files.java:2670)
	at java.nio.file.Files.walkFileTree(Files.java:2742)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)

liferay-forms · 2020-10-21T15:00:20Z

Hey @marcosapmf, can you please check if these failures are related to your changes? Thanks

carolmariaabb · 2020-10-21T15:05:22Z

ci:test:relevant

liferay-continuous-integration · 2020-10-21T15:14:12Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#3422
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:carolmariaabb#236
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:relevant
Spira Release Build:master - marcosapmf > carolmariaabb - PR#236 - 2020-10-21[05:50:20]
Spira Jenkins Build:publish-spira-report#9914

liferay-continuous-integration · 2020-10-21T17:08:48Z

✔️ ci:test:stable - 14 out of 14 jobs passed

❌ ci:test:relevant - 114 out of 119 jobs passed in 2 hours 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: e035cc567da2b8aba5f511714e052127ef347634

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 27bc57847a0fbdd19ff9c855a0e2eda43d622c23

ci:test:stable - 14 out of 14 jobs PASSED

14 Successful Jobs:

ci:test:relevant - 114 out of 119 jobs PASSED

5 Failed Jobs:

114 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk8

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #444016

Triggering projects: verification-node [liferay-jenkins-ee] $ /bin/bash -e -x /tmp/jenkins7842459471171543354.sh + echo 'Update the workspace repository for post-build steps.' Update the workspace repository for post-build steps. + git clean -d -f -x Removing git/ Removing hs_err_pid13804.log + git reset --hard HEAD is now at b0410f6dc9 LRCI-1643 Move 'environments' upstream suite away from private branches + set +e + git show-ref --verify --quiet refs/heads/master-temp-1603296150601 + VERIFY_BRANCH_RESULT=0 + set -e + [[ 0 == 0 ]] + git checkout master-temp-1603296150601 Already on 'master-temp-1603296150601' + git log -n 1 commit b0410f6dc978823717c69b05be2587465e878b5a Author: yichenroy <yi-chen.tsai@liferay.com> Date: Tue Oct 20 10:02:44 2020 -0700 LRCI-1643 Move 'environments' upstream suite away from private branches echo 'Exit shell.' Exit shell. [liferay-jenkins-ee] $ /bin/bash -e -x /tmp/jenkins8386830295051053587.sh echo 'Execute: build-test-portal-acceptance-pullrequest-batch.sh stop-current-job' Execute: build-test-portal-acceptance-pullrequest-batch.sh stop-current-job commands/build-test-portal-acceptance-pullrequest-batch.sh stop-current-job Execute: ant -f commands/build-common.xml run-ant-target -Dant.file.name=build-test-portal-acceptance-pullrequest-batch.xml -Dant.target=stop-current-job -lib commands/../lib/jenkins Java HotSpot(TM) 64-Bit Server VM warning: INFO: os::commit_memory(0x00000006c0000000, 805306368, 0) failed; error='Cannot allocate memory' (errno=12) There is insufficient memory for the Java Runtime Environment to continue. Native memory allocation (mmap) failed to map 805306368 bytes for committing reserved memory. An error report file with more information is saved as: /opt/dev/projects/github/liferay-jenkins-ee/hs_err_pid13847.log

[EnvInject] - Injecting environment variables from a build step. [EnvInject] - [ERROR] - The given properties file path '/opt/dev/projects/github/liferay-jenkins-ee/stop.properties' doesn't exist. [EnvInject] - [ERROR] - Missing file path was resolved from pattern '${WORKSPACE}/stop.properties' . [EnvInject] - [ERROR] - Problems occurs on injecting env vars as a build step: java.io.IOException: The given properties file path '/opt/dev/projects/github/liferay-jenkins-ee/stop.properties' doesn't exist. [description-setter] Description set: ${BUILD_DESCRIPTION} Build step 'Execute Scripts' marked build as failure Finished: FAILURE

test-portal-acceptance-pullrequest-batch(master)/modules-unit-project-templates-jdk8

Job Results:

1 Test Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #444017

Triggering projects: verification-node [liferay-jenkins-ee] $ /bin/bash -e -x /tmp/jenkins2724061227355544207.sh echo 'Update the workspace repository for post-build steps.' Update the workspace repository for post-build steps. git clean -d -f -x Removing git/ Removing hs_err_pid17937.log git reset --hard HEAD is now at b0410f6dc9 LRCI-1643 Move 'environments' upstream suite away from private branches set +e git show-ref --verify --quiet refs/heads/master-temp-1603296151044 VERIFY_BRANCH_RESULT=0 set -e [[ 0 == 0 ]] git checkout master-temp-1603296151044 Already on 'master-temp-1603296151044' git log -n 1 commit b0410f6dc978823717c69b05be2587465e878b5a Author: yichenroy <yi-chen.tsai@liferay.com> Date: Tue Oct 20 10:02:44 2020 -0700 LRCI-1643 Move 'environments' upstream suite away from private branches echo 'Exit shell.' Exit shell. [liferay-jenkins-ee] $ /bin/bash -e -x /tmp/jenkins7618613223207123578.sh echo 'Execute: build-test-portal-acceptance-pullrequest-batch.sh stop-current-job' Execute: build-test-portal-acceptance-pullrequest-batch.sh stop-current-job commands/build-test-portal-acceptance-pullrequest-batch.sh stop-current-job Execute: ant -f commands/build-common.xml run-ant-target -Dant.file.name=build-test-portal-acceptance-pullrequest-batch.xml -Dant.target=stop-current-job -lib commands/../lib/jenkins Java HotSpot(TM) 64-Bit Server VM warning: INFO: os::commit_memory(0x00000006c0000000, 805306368, 0) failed; error='Cannot allocate memory' (errno=12) There is insufficient memory for the Java Runtime Environment to continue. Native memory allocation (mmap) failed to map 805306368 bytes for committing reserved memory. An error report file with more information is saved as: /opt/dev/projects/github/liferay-jenkins-ee/hs_err_pid18024.log

[EnvInject] - Injecting environment variables from a build step. [EnvInject] - [ERROR] - The given properties file path '/opt/dev/projects/github/liferay-jenkins-ee/stop.properties' doesn't exist. [EnvInject] - [ERROR] - Missing file path was resolved from pattern '${WORKSPACE}/stop.properties' . [EnvInject] - [ERROR] - Problems occurs on injecting env vars as a build step: java.io.IOException: The given properties file path '/opt/dev/projects/github/liferay-jenkins-ee/stop.properties' doesn't exist. [description-setter] Description set: ${BUILD_DESCRIPTION} Build step 'Execute Scripts' marked build as failure Finished: FAILURE

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/61
Job Results:
1 Test Passed.
1 Test Failed.
1. AXIS_VARIABLE=0,label_exp=!master #451646
  1. LocalFile.Forms#SubmitFormWithAllFieldTypesAndThreePages - Poshi Report - Poshi Summary - Console Output
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/65
Job Results:
1 Test Passed.
1 Test Failed.
1. AXIS_VARIABLE=0,label_exp=!master #204697
  1. LocalFile.Forms#EditTranslatedGridField - Poshi Report - Poshi Summary - Console Output

For upstream results, click here.

liferay-forms · 2020-10-21T17:08:50Z

Hey @marcosapmf, can you please check if these failures are related to your changes? Thanks

liferay-continuous-integration · 2020-10-21T17:14:35Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#7328
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:carolmariaabb#236
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:relevant
Spira Release Build:master - marcosapmf > carolmariaabb - PR#236 - 2020-10-21[08:05:47]
Spira Jenkins Build:publish-spira-report#6810

carolmariaabb · 2020-10-21T17:16:23Z

@marcosapmf to corrigindo os testes de poshi que falharam por causa do option ID que não ta mais la.

carolmariaabb · 2020-10-21T17:53:56Z

Just started reviewing :)

Sent from GH.

carolmariaabb · 2020-10-21T18:20:04Z

Pull request submitted to carolmariaabb#239.

Sent from GH.

carolmariaabb · 2020-10-21T18:20:24Z

Closed #236.

Sent from GH.

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - pending labels Oct 21, 2020

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending labels Oct 21, 2020

carolmariaabb reviewed Oct 21, 2020

View reviewed changes

...pping-form-builder/src/main/resources/META-INF/resources/js/components/Sidebar/Sidebar.es.js Show resolved Hide resolved

marcosapmf added 5 commits October 21, 2020 11:47

LPS-122028 hide field name input on sidebar

e4c8b71

LPS-122028 hide option name by default on Sidebar

efcfd92

LPS-122028 fix test

4daea7d

LPS-122028 regen snapshots

f1060c4

LPS-122028 create unit tests

11076c7

marcosapmf force-pushed the LPS-122028 branch from 5db2bd8 to 11076c7 Compare October 21, 2020 14:47

carolmariaabb added the reviewed label Oct 21, 2020

liferay-continuous-integration added ci:test:relevant - failure ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Oct 21, 2020

liferay-continuous-integration added ci:test:relevant - pending and removed ci:test:relevant - failure labels Oct 21, 2020

liferay-continuous-integration added ci:test:stable - pending and removed ci:test:stable - success labels Oct 21, 2020

carolmariaabb added the waiting-ci-to-forward label Oct 21, 2020

liferay-continuous-integration added ci:test:relevant - failure ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Oct 21, 2020

carolmariaabb closed this Oct 21, 2020

LPS-122028 create unit tests #236

LPS-122028 create unit tests #236

Conversation

marcosapmf commented Oct 21, 2020 • edited by liferay-forms

liferay-forms commented Oct 21, 2020

liferay-forms commented Oct 21, 2020

liferay-continuous-integration commented Oct 21, 2020

liferay-continuous-integration commented Oct 21, 2020

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-forms commented Oct 21, 2020

carolmariaabb commented Oct 21, 2020

liferay-continuous-integration commented Oct 21, 2020

carolmariaabb commented Oct 21, 2020

liferay-continuous-integration commented Oct 21, 2020

✔️ ci:test:stable - 14 out of 14 jobs passed

❌ ci:test:relevant - 114 out of 119 jobs passed in 2 hours 9 minutes

Base Branch:

Copied in Private Modules Branch:

5 Failed Jobs:

For more details click here.

Failures unique to this pull:

Job Results:

Job Results:

Job Results:

Job Results:

liferay-forms commented Oct 21, 2020

carolmariaabb commented Oct 21, 2020

liferay-continuous-integration commented Oct 21, 2020

liferay-continuous-integration commented Oct 21, 2020

✔️ ci:test:stable - 14 out of 14 jobs passed

❌ ci:test:relevant - 114 out of 119 jobs passed in 2 hours 3 minutes

Base Branch:

Copied in Private Modules Branch:

5 Failed Jobs:

For more details click here.

Failures unique to this pull:

Job Results:

There is insufficient memory for the Java Runtime Environment to continue.

Native memory allocation (mmap) failed to map 805306368 bytes for committing reserved memory.

An error report file with more information is saved as:

/opt/dev/projects/github/liferay-jenkins-ee/hs_err_pid13847.log

Job Results:

There is insufficient memory for the Java Runtime Environment to continue.

Native memory allocation (mmap) failed to map 805306368 bytes for committing reserved memory.

An error report file with more information is saved as:

/opt/dev/projects/github/liferay-jenkins-ee/hs_err_pid18024.log

Job Results:

Job Results:

For upstream results, click here.

liferay-forms commented Oct 21, 2020

liferay-continuous-integration commented Oct 21, 2020

carolmariaabb commented Oct 21, 2020 • edited

carolmariaabb commented Oct 21, 2020

carolmariaabb commented Oct 21, 2020

carolmariaabb commented Oct 21, 2020

marcosapmf commented Oct 21, 2020 •

edited by liferay-forms

carolmariaabb commented Oct 21, 2020 •

edited