AppriseLocale Deprication Warning: Use setlocale(), getencoding() and getlocale() instead

[caronc]

📣 Notification Service(s) Impacted
All

🐞 Describe the bug
The following warning appears when building on newer Python versions

AppriseLocale.py:209: DeprecationWarning: Use setlocale(), getencoding() and getlocale() instead
    lang = locale.getdefaultlocale()[0]

Won't be a problem now, but should be addressed so there aren't any surprises in a future release.

💻 Your System Details:

• Python Version: v3.10

🔮 Additional context
Add any other context about the problem here.

[caronc]

@amotl , if i didn't know better, I think you fixed this with your massive test re-factoring?

[amotl]

Hi Chris, indeed I quickly looked into it, but had to back out of it again, after I didn't see a successful outcome, within the constraints/boundaries of the effort needed for the other refactorings and improvements. Apologies about this, but I believe you may be able to make a faster progress on this, because you know the corresponding subsystem better than me, who actually doesn't even know what he is doing, most of the time ;). With kind regards, Andreas.

[caronc]

No worries at all... you've just provided me so much code to review, i thought i spotted this and wanted to double check. No worries at all here. We'll leave this ticket open and i'll get to it soon enough.

[dpeet]

@caronc what is holding up the merge for this? I just encountered this error in a 3.11 codebase and came here to make a PR, and realized not only had you already done it but it was way better than my naive approach would have been!

[caronc]

The until tests fail for older versions of Python. Different versions of the older Python packages also have different results for the same test. It's just really inconsistent and i hadn't had time to investigate why.