Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Telegram attachments respect topic thread #893

Merged
merged 1 commit into from Jun 24, 2023

Conversation

caronc
Copy link
Owner

@caronc caronc commented Jun 24, 2023

Description:

Related issue (if applicable): #881

Bugfix to allow attachments to properly get posted to the topic they were specified for.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@881-telegram-images-in-thread

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" \
  "tgram://credentials/?topic=setme" \
  --attach=/a/path/to/a/file/to/attach

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ab55aef) 100.00% compared to head (e99190f) 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #893   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          118       118           
  Lines        15692     15694    +2     
  Branches      3211      3212    +1     
=========================================
+ Hits         15692     15694    +2     
Impacted Files Coverage Δ
apprise/plugins/NotifyTelegram.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@caronc caronc merged commit b6e07dd into master Jun 24, 2023
14 checks passed
@caronc caronc deleted the 881-telegram-images-in-thread branch June 25, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants