Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve split and truncate overflow methods #1035

Merged
merged 6 commits into from Dec 29, 2023

Conversation

caronc
Copy link
Owner

@caronc caronc commented Dec 29, 2023

Description:

Related issue (if applicable): #845

Improve ?overflow=split and ?overflow=truncate functionality to factor in the length of the title in it's calculations.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@845-bodylen-overflow-improvement

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" \
  <apprise url related to ticket>

@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c240f8b) 99.27% compared to head (cf6c683) 99.27%.
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1035   +/-   ##
=======================================
  Coverage   99.27%   99.27%           
=======================================
  Files         135      135           
  Lines       17557    17574   +17     
  Branches     3583     3588    +5     
=======================================
+ Hits        17429    17446   +17     
  Misses        119      119           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caronc caronc merged commit f3c699a into master Dec 29, 2023
12 checks passed
@caronc caronc deleted the 845-bodylen-overflow-improvement branch February 3, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants