Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored (Split and Truncate) Overflow Engine #1038

Merged
merged 7 commits into from Jan 6, 2024

Conversation

caronc
Copy link
Owner

@caronc caronc commented Dec 31, 2023

Description:

Related issue (if applicable): #845

A massive refactoring of the Overflow Engine handling the truncate and split functionality. A more dynamic and clean presentation can be adapted per upstream service.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@845-overflow-continued-improvements

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" \
  <apprise url related to ticket>?overflow=split

@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f3c699a) 99.27% compared to head (11ba9e9) 99.27%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1038   +/-   ##
=======================================
  Coverage   99.27%   99.27%           
=======================================
  Files         135      135           
  Lines       17574    17600   +26     
  Branches     3588     3592    +4     
=======================================
+ Hits        17446    17472   +26     
  Misses        119      119           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caronc caronc merged commit 1da1d48 into master Jan 6, 2024
12 checks passed
@caronc caronc deleted the 845-overflow-continued-improvements branch February 3, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants