Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comcast.net email template added #1059

Merged
merged 1 commit into from Feb 21, 2024
Merged

Conversation

caronc
Copy link
Owner

@caronc caronc commented Feb 10, 2024

Description:

Related issue (if applicable): #1058

comcast.net email template added. Users of comcast can format their email using apprise as:

  • mailto://user:pass@comcast.net

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@1058-comcast-email-template

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" \
  "mailto://user:pass@comcast.net"

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (31a4f2e) 99.27% compared to head (6998f99) 99.27%.
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1059   +/-   ##
=======================================
  Coverage   99.27%   99.27%           
=======================================
  Files         135      135           
  Lines       17600    17603    +3     
  Branches     3592     3593    +1     
=======================================
+ Hits        17472    17475    +3     
  Misses        119      119           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caronc
Copy link
Owner Author

caronc commented Feb 21, 2024

Based configuration off of official documentation .

@caronc caronc merged commit 010be0b into master Feb 21, 2024
12 checks passed
@caronc caronc deleted the 1058-comcast-email-template branch April 6, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants