Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ntfy loaded topic count bugfix #1094

Merged
merged 1 commit into from Apr 6, 2024
Merged

ntfy loaded topic count bugfix #1094

merged 1 commit into from Apr 6, 2024

Conversation

caronc
Copy link
Owner

@caronc caronc commented Apr 6, 2024

Description:

Related issue (if applicable): n/a

All services should return 1 at the very least; never 0 when getting a count.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@ntfy-len-bugfix

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" \
  ntfy://host/topic

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.27%. Comparing base (26d8e45) to head (34725d4).
Report is 15 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1094      +/-   ##
==========================================
- Coverage   99.27%   99.27%   -0.01%     
==========================================
  Files         136      138       +2     
  Lines       17753    17954     +201     
  Branches     3623     3663      +40     
==========================================
+ Hits        17625    17824     +199     
- Misses        119      121       +2     
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caronc caronc merged commit 6cd528c into master Apr 6, 2024
12 checks passed
@caronc caronc deleted the ntfy-len-bugfix branch April 8, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants