Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freemobile:// msg moved from GET parameters and into payload #1106

Merged
merged 1 commit into from Apr 13, 2024

Conversation

caronc
Copy link
Owner

@caronc caronc commented Apr 13, 2024

Description:

Related issue (if applicable): #1090

Bugfix to move msg into payload (and out of kwarg GET parameters)

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@1090-mobile-free-bugfix

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" \
  freemobile://user@password

@caronc
Copy link
Owner Author

caronc commented Apr 13, 2024

@rabonarca would you mind giving this branch a try to see if it helps your situation?

@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.27%. Comparing base (cced5ed) to head (36393b1).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1106      +/-   ##
==========================================
- Coverage   99.27%   99.27%   -0.01%     
==========================================
  Files         139      139              
  Lines       18029    18028       -1     
  Branches     3680     3680              
==========================================
- Hits        17899    17898       -1     
  Misses        121      121              
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caronc caronc merged commit da5caf7 into master Apr 13, 2024
13 checks passed
@caronc caronc deleted the 1090-mobile-free-bugfix branch April 13, 2024 23:58
@rabonarca
Copy link

rabonarca commented Apr 14, 2024

@rabonarca would you mind giving this branch a try to see if it helps your situation?

With the changes I proposed it still didn't work.
As I had more time today for testing I managed to make it work by adding 'Content-Type': 'application/json' to the headers and keeping the msg in the payload.

@caronc
Copy link
Owner Author

caronc commented Apr 15, 2024

Fixed in #1109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants