Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Plugin Attachment Support Enforced + Added Testing #1115

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

caronc
Copy link
Owner

@caronc caronc commented Apr 20, 2024

Description:

Related issue (if applicable): #1110

Upon further investigating, the CustomPlugin always has a utf-8 character string; this is confirmed with the added test cases.

One thing to note that before this PR, the Custom Plugin module did not support Attachments (as it should have been allowed). This has been fixed in this PR.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

n/a - more unit tests added in this PR

@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.28%. Comparing base (22c979d) to head (242207f).
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1115   +/-   ##
=======================================
  Coverage   99.27%   99.28%           
=======================================
  Files         139      139           
  Lines       18053    18056    +3     
  Branches     3688     3689    +1     
=======================================
+ Hits        17923    17926    +3     
  Misses        121      121           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caronc caronc merged commit 1f77254 into master Apr 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants