Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update apprise_api token length #1120

Merged
merged 1 commit into from
May 3, 2024

Conversation

isometimescode
Copy link
Contributor

@isometimescode isometimescode commented May 3, 2024

Description:

Related issue (if applicable): caronc/apprise-api#187

It looks like the apprise-api README suggests a key length of up to 128 chars, so updating the apprise_api plugin token check seemed appropriate.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/isometimescode/apprise.git@apprise-api-token-length

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" \
  apprise://example.com/asdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdf

@isometimescode
Copy link
Contributor Author

Also, I'm not sure if it's worth updating the wiki page at https://github.com/caronc/apprise/wiki/Notify_apprise_api, but that would be up to you since I can't submit a PR for that.

@caronc
Copy link
Owner

caronc commented May 3, 2024

This is great! I'll definitely update the wiki. Thank you for the PR 🙏🚀

@caronc caronc merged commit fcd70ff into caronc:master May 3, 2024
13 checks passed
@isometimescode isometimescode deleted the apprise-api-token-length branch May 3, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants