Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clicksend:// authentication bugfix #1121

Merged
merged 2 commits into from
May 5, 2024
Merged

clicksend:// authentication bugfix #1121

merged 2 commits into from
May 5, 2024

Conversation

caronc
Copy link
Owner

@caronc caronc commented May 5, 2024

Description:

Related issue (if applicable): #1103

Previous to this merge request, clicksend://user:apikey did not work correctly

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@1103-clicksend-authfix

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" \
  "clicksend://user:apikey@..."

@caronc caronc changed the title clicksend:// authentication bufix clicksend:// authentication bugfix May 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.28%. Comparing base (fcd70ff) to head (006c5fe).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1121   +/-   ##
=======================================
  Coverage   99.28%   99.28%           
=======================================
  Files         139      139           
  Lines       18066    18067    +1     
  Branches     3689     3690    +1     
=======================================
+ Hits        17936    17937    +1     
  Misses        121      121           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caronc caronc merged commit 5fd912f into master May 5, 2024
13 checks passed
@caronc caronc deleted the 1103-clicksend-authfix branch May 7, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants