Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix - Global parameters placed in url() again #275

Merged
merged 1 commit into from Aug 17, 2020

Conversation

caronc
Copy link
Owner

@caronc caronc commented Aug 17, 2020

Description:

There was a bug created/missed when merging #264 causing the extra URL arguments to not be replaced in the url() calls. This is now fixed.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

@caronc caronc changed the title bugfix to return default global parameters Bugfix - Global parameters placed in url() again Aug 17, 2020
@caronc caronc changed the title Bugfix - Global parameters placed in url() again Bugfix - Global parameters placed in url() again Aug 17, 2020
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2020

Codecov Report

Merging #275 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #275   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           83        83           
  Lines         9756      9756           
  Branches      1562      1562           
=========================================
  Hits          9756      9756           
Impacted Files Coverage Δ
apprise/plugins/NotifyBase.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca695ed...6ca5e54. Read the comment docs.

@caronc caronc merged commit fbaf1e4 into master Aug 17, 2020
@caronc caronc deleted the url-construction-fix branch August 19, 2020 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants