Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced email parsing added; eg: Full Name email@domain.com #276

Merged
merged 6 commits into from Aug 18, 2020

Conversation

caronc
Copy link
Owner

@caronc caronc commented Aug 18, 2020

Description:

Related issue (if applicable): #271

Email addresses can now be parsed as:

  • Full Name user@domain.com
  • Full Name: user@domain.com
  • Full Name <user@domain.com>
  • Full Name : <user@domain.com>
  • <user@domain.com>

As well as the legacy format:

  • user@domain.com
  • label+user@domain.com

Some providers (such as SMTP/EMail will use the Full Name and incorporate it in the email. For example:

  • mailto://user:pass@gmail.com/Joe%20Rogan:jr@joerogan.net would log into your gmail account and associate Joe Rogan with the To email jr@joerogan.net
  • mailto://user:pass@gmail.com/?cc=Uncle%Ben:ben@unclebens.com would log into your gmail account and send an email to you while CCing ben@unclebens.com and associating Uncle Ben with it.
  • Office 365 Plugin now supports bcc and cc which in itself also supports the new email messaging format

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

@caronc
Copy link
Owner Author

caronc commented Aug 18, 2020

@maranqz this is for you! 🙂

It's not done yet since it turned out to be a massive change. I still want to do more testing of my own, but it would be awesome if you could test it out for me too and let me know if it works for you too!

@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2020

Codecov Report

Merging #276 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #276   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           83        83           
  Lines         9756      9846   +90     
  Branches      1562      1603   +41     
=========================================
+ Hits          9756      9846   +90     
Impacted Files Coverage Δ
apprise/Apprise.py 100.00% <100.00%> (ø)
apprise/plugins/NotifyEmail.py 100.00% <100.00%> (ø)
apprise/plugins/NotifyOffice365.py 100.00% <100.00%> (ø)
apprise/plugins/NotifyPopcornNotify.py 100.00% <100.00%> (ø)
apprise/plugins/NotifyPushBullet.py 100.00% <100.00%> (ø)
apprise/plugins/NotifySendGrid.py 100.00% <100.00%> (ø)
apprise/plugins/NotifyTwist.py 100.00% <100.00%> (ø)
apprise/plugins/NotifyZulip.py 100.00% <100.00%> (ø)
apprise/plugins/__init__.py 100.00% <100.00%> (ø)
apprise/utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbaf1e4...61dc325. Read the comment docs.

@maranqz
Copy link

maranqz commented Aug 18, 2020

@caronc
Sorry, I don't have enough time, but I might possibly try to do it on weekend .

@caronc caronc merged commit 6e1b8a0 into master Aug 18, 2020
@caronc caronc deleted the 271-advanced-email-parsing branch August 19, 2020 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants