Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor deprecation notices by removing them and accompanied code #283

Merged
merged 2 commits into from Aug 28, 2020

Conversation

caronc
Copy link
Owner

@caronc caronc commented Aug 28, 2020

Description:

Related issue (if applicable): n/a

Just some code clean up; there have been deprecation warnings that date back more than a year now:

  • Twitter: tweet:// is not an accepted schema to initialize it with.
    • Deprecation warning since Jun 29th, 2019 (14 months)
  • Discord: thumbnail= was switched to image= for consistency with other plugins
    • Deprecation warning since April 5th, 2019 (17 months)
  • Matrix: There were 2 deprecations cleaned up here:
    1. Determining the type of webhook mode used is identified by mode= not webhook=; this was done for consistency with other plugins.
      - Deprecation warning since April 5th, 2019 (17 months)
    2. thumbnail= was switched to image= for consistency with other plugins
      - Deprecation warning since April 5th, 2019 (17 months)
  • Pushjet: secret_key@hostame is no longer accepted. The syntax is hostname/secret_key. This was to remove conflicting cases where user:pass@hostname/secret_key was used.
    • Deprecation warning since Sept 7th, 2019 (12 months)
  • Ryver: Determining the type of webhook mode used is identified by mode= not webhook=; this was done for consistency with other plugins.
    - Deprecation warning since April 5th, 2019 (17 months)

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2020

Codecov Report

Merging #283 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #283   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           83        83           
  Lines         9942      9927   -15     
  Branches      1617      1611    -6     
=========================================
- Hits          9942      9927   -15     
Impacted Files Coverage Δ
apprise/plugins/NotifyPushjet.py 100.00% <ø> (ø)
apprise/plugins/NotifyDiscord.py 100.00% <100.00%> (ø)
apprise/plugins/NotifyMatrix.py 100.00% <100.00%> (ø)
apprise/plugins/NotifyRyver.py 100.00% <100.00%> (ø)
apprise/plugins/NotifyTwitter.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dfd429...20060a2. Read the comment docs.

@caronc caronc merged commit 66d285a into master Aug 28, 2020
@caronc caronc changed the title Honor deprecated content by removing it and accompanied warnings Honor deprecation notices by removing them and accompanied code Aug 28, 2020
@caronc caronc deleted the deprecation-warning-cleanup branch August 28, 2020 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants