Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rocket.chat basic message structure fix #419

Merged
merged 1 commit into from Aug 8, 2021

Conversation

caronc
Copy link
Owner

@caronc caronc commented Aug 7, 2021

Description:

Related issue (if applicable): #406

This resolves an issue identified where basic Rocket.Chat messages would not work properly (however webhook worked fine).

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in
# This way you can just destroy it after when it's all over.
# The below will create a directory called apprise
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@406-rocket-chat-message-posting
# Give it a go:
# The syntax is like so:
# swap {values} accordingly:
apprise -t "Title" -b "Body" "rockets://{user}:{pass}@{host}"

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2021

Codecov Report

Merging #419 (ad91da5) into master (49af85b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #419   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           94        94           
  Lines        11968     11972    +4     
  Branches      2012      2016    +4     
=========================================
+ Hits         11968     11972    +4     
Impacted Files Coverage Δ
apprise/plugins/NotifyRocketChat.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49af85b...ad91da5. Read the comment docs.

@hkpanchani
Copy link

hkpanchani commented Aug 8, 2021

@caronc
Thank you!!! Issue Resolved and can be pushed to release.
Can you share the procedure how can I update the existing apprise!?

@caronc caronc merged commit 0b26d1c into master Aug 8, 2021
@caronc
Copy link
Owner Author

caronc commented Aug 8, 2021

@hkpanchani : The content is merged to the master now; it will be part of the next official build. But in the meantime, if you want to use it just install the master branch here (instead of what is in PyPi) into whatever environment it is you need it in:

# Install master branch:
pip install git+https://github.com/caronc/apprise.git

@caronc caronc deleted the 406-rocket-chat-message-posting branch August 12, 2021 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants