Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nextcloud versioning support added #432

Merged
merged 2 commits into from Aug 29, 2021
Merged

Conversation

caronc
Copy link
Owner

@caronc caronc commented Aug 21, 2021

Description:

Related issue (if applicable): #395 and #371. Additionally PR #429

Added ?version= value to Nextcloud URL. It will default to 21 if not otherwise specified. Those using an earlier version can identify it.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in
# This way you can just destroy it after when it's all over.
# The below will create a directory called apprise
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@371-nextcloud-version-support
# Give it a go:
# The following will run for version 21 (default):
apprise -t "Title" -b "Body" "ncloud://{user}:{pass}@{host}"

# But you can optionally over-ride this and access the older API calls by doing the following:
apprise -t "Title" -b "Body" "ncloud://{user}:{pass}@{host}/?version=20"

@caronc caronc merged commit 81d1ea7 into master Aug 29, 2021
@caronc caronc deleted the 371-nextcloud-version-support branch September 18, 2021 18:31
@amitsax
Copy link

amitsax commented Mar 4, 2022

Wiki needs update for this fix: https://github.com/caronc/apprise/wiki/Notify_nextcloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants