Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape new lines for TEXT->HTML conversions #617

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

caronc
Copy link
Owner

@caronc caronc commented Jul 1, 2022

Description:

Related issue (if applicable): #616

Bugfix introduced in Apprise v0.9.9 where \n is no longer correctly escaped when converting from TEXT -> HTML as a result of past code re-factoring.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@/616-text-to-html-crlf-fix

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" \
  "<apprise url>"

@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2022

Codecov Report

Merging #617 (79f0db3) into master (1519e98) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #617   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          112       112           
  Lines        14416     14416           
  Branches      2725      2725           
=========================================
  Hits         14416     14416           
Impacted Files Coverage Δ
apprise/URLBase.py 100.00% <100.00%> (ø)
apprise/conversion.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1519e98...79f0db3. Read the comment docs.

@caronc caronc merged commit e954843 into master Jul 1, 2022
@caronc caronc deleted the 616-text-to-html-crlf-fix branch July 14, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants