Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/setup travis ci #1

Merged
merged 5 commits into from
Apr 28, 2017
Merged

Feature/setup travis ci #1

merged 5 commits into from
Apr 28, 2017

Conversation

jianyaoang
Copy link
Contributor

Task Done

  • Added .travis.yml file
  • Updated .gitignore file to exclude .DS_Store

@jianyaoang jianyaoang requested a review from bcylin April 19, 2017 09:29
.travis.yml Outdated
language: objective-c

xcode_project: Pickle.xcworkspace
xcode_scheme: Tests.swift
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be Pickle-Example? Tests.swift is not one of the shared schemes in the project.

Copy link
Collaborator

@bcylin bcylin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jianyaoang please also set up Slack notifications

Copy link
Collaborator

@bcylin bcylin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @jianyaoang 👍

@jianyaoang jianyaoang merged commit bb35278 into master Apr 28, 2017
@bcylin bcylin deleted the feature/setup-travis-ci branch May 16, 2017 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants