Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3D Touch Photo Preview #3

Merged
merged 2 commits into from
May 16, 2017
Merged

3D Touch Photo Preview #3

merged 2 commits into from
May 16, 2017

Conversation

bcylin
Copy link
Collaborator

@bcylin bcylin commented May 9, 2017

  • Add a PhotoDetailViewController for displaying photo preview
  • Conform PhotoGalleryViewController to UIViewControllerPreviewingDelegate
  • Remove Main.storyboard from the example project

@@ -72,9 +72,9 @@ internal class PhotoGalleryViewController: UIViewController,

private let album: PHAssetCollection
private let configuration: ImagePickerConfigurable?
private lazy var isCameraCompatible: Bool = self.album.isCameraCompatible
private(set) lazy var isCameraCompatible: Bool = self.album.isCameraCompatible
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bcylin reminder to add internal

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated with internal, thanks!

Copy link
Contributor

@jianyaoang jianyaoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bcylin bcylin merged commit 4f8252f into master May 16, 2017
@bcylin bcylin deleted the feature/photo-preview branch May 16, 2017 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants