Photo Albums Layout #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bcylin
commented
Jul 11, 2017
bcylin
commented
- Fix the shadow of navigation bar when photo albums are displayed
- Fix the gap between the navigation bar and photo albums after device rotation
|
@burnflare, can you review this pull request? |
Generated by 🚫 Danger |
burnflare
approved these changes
Jul 14, 2017
.travis.yml
Outdated
| @@ -7,6 +7,9 @@ cache: | |||
| directories: | |||
| - vendor/bundle | |||
| - Example/Pods/SwiftLint | |||
| before_install: | |||
| - xcrun instruments -s devices | |||
| - xcrun instruments -w "iPhone SE (10.3.1) [" || true | |||
There was a problem hiding this comment.
Wanna use iPhone 7 like https://github.com/carousell/Carousell-iOS/pull/397?
|
|
||
| private lazy var shadawLayer: CALayer = { | ||
| let layer = CALayer() | ||
| layer.borderColor = UIColor.Palette.magnesium.cgColor |
There was a problem hiding this comment.
Should these colours be abstracted out to a theming engine of some sort since this is going to be OSS and people might want to change colors?
There was a problem hiding this comment.
Good idea, although it's just for the 1px fake shadow below the navigation bar when the album list is presented.
bcylin
force-pushed
the
feature/photo-albums-layout
branch
from
95cb7fa
to
48f90fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.