-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Prefer nbmake
plugin for testing notebooks
#207
ENH: Prefer nbmake
plugin for testing notebooks
#207
Conversation
✅ Deploy Preview for carpentries-dmri ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Does not seem to provide a cell-wise report, but at least the |
Prefer using the `nbmake` plugin over `nbval` for testing notebooks. `nbval`'s `timeout` flag to explicitly set the cell execution time is not working properly, and most `preprocessing` notebook cells were not being run. Documentation: https://pypi.org/project/nbmake/
hi @jhlegarreta -- I maintain nbmake (sorry to intrude)
Why would this help? Feature requests welcome 👍 |
@alex-treebeard No worries; we appreciate the time spent developing the plugin, and your interest on our use case.
It's maybe a matter of preferences/nice-to-have feature, although, in practice, when a cell fails we still know which cell is the culprit. A cell-wise report, as we had in the past using Also, without diving into the error trace, the report/summary shows the error type. In addition, The latter is useful because if we make changes to multiple cells across different notebooks, we'd rather know the errors at once to save CI wait times, be able to fix all issues at once, and ultimately save ourselves time. Even more so when testing (including our setup steps) takes so long. |
Prefer using the
nbmake
plugin overnbval
for testing notebooks.nbval
'stimeout
flag to explicitly set the cell execution time isnot working properly, and most
preprocessing
notebook cells were notbeing run.
Documentation:
https://pypi.org/project/nbmake/