Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with search #1819

Closed
fmichonneau opened this issue Mar 2, 2021 · 1 comment
Closed

Issue with search #1819

fmichonneau opened this issue Mar 2, 2021 · 1 comment
Assignees
@pbanaszkiewicz
Labels
priority: essential type: bug
Milestone
v3.0

Comments

@fmichonneau
Copy link
Contributor

Search results now tend to return a single match (either a person's profile or their training request) even when both exist. In the past, in such situations, the search interface result would list all possible matches.

Another example is looking for "OSU" that brings directly to the associated membership page instead of also including events that include this acronym in their slug.
@pbanaszkiewicz pbanaszkiewicz self-assigned this Mar 2, 2021
@pbanaszkiewicz pbanaszkiewicz added this to the v2.17 milestone Mar 2, 2021
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Mar 2, 2021
@pbanaszkiewicz
[carpentries#1819] Fix search for single result
4a55b57 
When one result group contained single result, the other results would
be ignored. This fixes the invalid logic.
pbanaszkiewicz added a commit that referenced this issue Mar 6, 2021
@pbanaszkiewicz
Merge pull request #1821 from pbanaszkiewicz/bugfix/1819-fix-search-f…
3f5e383 
…or-single-results

[#1819] Fix search for single result
@pbanaszkiewicz
Copy link
Contributor

Closed via PR #1821.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pbanaszkiewicz pbanaszkiewicz

Labels
priority: essential type: bug
Projects
None yet
Milestone
v3.0
Development

No branches or pull requests
2 participants
@pbanaszkiewicz @fmichonneau