Make accordion work in Django form #1733
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbanaszkiewicz
added
component: user interface (UI)
javascript
pbanaszkiewicz
requested changes
Nov 1, 2020
There was a problem hiding this comment.
Hi @marwahaha, thank you for the pull request. I looked around and turns out the reason accordion doesn't work is old version of Bootstrap. I think upgrading to v4.5 branch should fix the issue.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1723
The accordion worked fine when I copied the HTML into a JSFiddle. I noticed that triggering the "collapse" function in JavaScript allowed the accordion to work again.
It seems that the field was hidden intentionally for the pre-filled group name. I removed that in light of #1723.
Hopefully I did this correctly!
Unfortunately, I'm not sure the best way to test for this behavior.