Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(Consents): Add Existing terms to the consents models in a migration. #1896

Merged
merged 2 commits into from
Apr 17, 2021
Merged

feature(Consents): Add Existing terms to the consents models in a migration. #1896

merged 2 commits into from
Apr 17, 2021

Conversation

lauryndbrown
Copy link
Contributor

@lauryndbrown lauryndbrown commented Apr 13, 2021 •
edited
Loading

Fixes #1870

  • Revised tests to inherit from a central base class.
  • Fixed tests to account for the terms in the db
  • changed fake_database to assume that there are terms in the database rather than create them itself.

Tested migration:

  • python manage.py migrate
  • python manage.py migrate consents 0003_term_help_text

@lauryndbrown lauryndbrown self-assigned this Apr 13, 2021
@lauryndbrown
Copy link
Contributor Author

The first is yes-only. The others are yes and no.

Screen Shot 2021-04-14 at 10 06 46 AM

@lauryndbrown lauryndbrown added the python Pull requests that update Python code label Apr 14, 2021
pbanaszkiewicz
pbanaszkiewicz approved these changes Apr 17, 2021
View reviewed changes
Copy link
Contributor

@pbanaszkiewicz pbanaszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@lauryndbrown lauryndbrown force-pushed the 1870/add-existing-terms-as-a-migration branch from a581477 to e6b6f61 Compare April 17, 2021 17:47
@lauryndbrown lauryndbrown force-pushed the 1870/add-existing-terms-as-a-migration branch from e6b6f61 to 47a2492 Compare April 17, 2021 19:16
@lauryndbrown lauryndbrown merged commit 627a837 into carpentries:develop Apr 17, 2021
@lauryndbrown lauryndbrown deleted the 1870/add-existing-terms-as-a-migration branch April 17, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbanaszkiewicz pbanaszkiewicz pbanaszkiewicz approved these changes

Assignees

@lauryndbrown lauryndbrown

Labels
component: database (DB) python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consents: Add Existing terms to the consents models in a migration.
2 participants
@lauryndbrown @pbanaszkiewicz