Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove glossary.yml from this repo #1

Closed
gvwilson opened this issue Jun 17, 2020 · 2 comments
Closed

Remove glossary.yml from this repo #1

gvwilson opened this issue Jun 17, 2020 · 2 comments
Assignees
@ian-flores
Labels
bug Something isn't working

Comments

@gvwilson
Copy link
Contributor

glosario/data/glossary.yml should not be in this repository - it should be downloaded dynamically during build (and included in .gitignore to prevent accidental addition in future).
@ian-flores ian-flores self-assigned this Jun 22, 2020
@ian-flores ian-flores added the bug Something isn't working label Jun 22, 2020
@zkamvar zkamvar mentioned this issue Jul 24, 2020
Open
@tonyfast
Copy link

super stoked on this project.

is the glossary.yml in https://github.com/carpentries/glosario/ always going to be the reference file for this project? is the idea each day the catalog will be updated from that repository?

@ian-flores
Copy link
Member

Hi @tonyfast I implemented something similar to what you mention here today in: https://github.com/carpentries/glosario-py/blob/master/.github/workflows/build_data.yaml. Just a GH Action to download the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ian-flores ian-flores

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gvwilson @tonyfast @ian-flores