Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP vs https links #1237

Open
brownsarahm opened this issue Apr 1, 2021 · 4 comments
Open

HTTP vs https links #1237

brownsarahm opened this issue Apr 1, 2021 · 4 comments

Comments

@brownsarahm
Copy link
Contributor

This is mostly important for the link to the community discussion pad, which currently links to a page that doesn't support HTTPS (before redirecting to another domain that supports HTTPS). Therefore, this causes issues in browsers that are configured for HTTPS-only navigation.

Originally raised through partial fix by @Bisaloo ! in #1236 (comment)

@brownsarahm
Copy link
Contributor Author

@karenword this should be added as one of the global fixes in the update

@Bisaloo
Copy link
Contributor

Bisaloo commented Apr 1, 2021

I realise now I could have indeed applied a similar fix to all files in the repo. Would you like me to submit a PR for this? Or is it something better left to someone with better knowledge of possible future major re-designs?

@karenword
Copy link
Contributor

Thank you @Bisaloo ! We are currently working on updates in a different repo, so I have created an issue there. We had done a pass-through on these at one point, but clearly a number of links were missed!

For most links I think it will be easiest for us to to address changes in the updates. However, if you happen across any others that cause problems urgently, please do submit those.

Thanks again -- this was a very useful catch!

@pachadotdev
Copy link

hi @karenword
should this issue be closed as well? I see that data-lessons#54 is closed and fixes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants