Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links to HTTPS #1236

Merged
merged 1 commit into from Apr 1, 2021
Merged

Update links to HTTPS #1236

merged 1 commit into from Apr 1, 2021

Conversation

Bisaloo
Copy link
Contributor

@Bisaloo Bisaloo commented Apr 1, 2021

This is mostly important for the link to the community discussion pad, which currently links to a page that doesn't support HTTPS (before redirecting to another domain that supports HTTPS). Therefore, this causes issues in browsers that are configured for HTTPS-only navigation.

This is mostly important for the link to the community discussion pad, which currently links to a page that doesn't support HTTPS (before redirecting to another domain that supports HTTPS). Therefore, this causes issues in browsers that are configured for HTTPS-only navigation.
@brownsarahm
Copy link
Contributor

brownsarahm commented Apr 1, 2021

Thank you @Bisaloo ! This is an important fix, so I'm going to merge it now, but also open an issue for checking this throughout the curriculum as a part of the current major update.

This is mostly important for the link to the community discussion pad, which currently links to a page that doesn't support HTTPS (before redirecting to another domain that supports HTTPS). Therefore, this causes issues in browsers that are configured for HTTPS-only navigation.

@brownsarahm brownsarahm merged commit ece8398 into carpentries:gh-pages Apr 1, 2021
@Bisaloo Bisaloo deleted the patch-1 branch April 1, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants