Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "the authors" translatable #582

Merged
merged 9 commits into from
May 7, 2024
Merged

Conversation

ErinBecker
Copy link
Contributor

@ErinBecker ErinBecker commented Apr 19, 2024

Fixes #579 by removing the hard coding English for {authors} and instead making the authors part of the {MaterialsLicensedUnder} variable. Also updates translation string for R-es.po.

Screenshot of Spanish language footer before:
Before - 'the authors' always shows in English

Screenshot of Spanish language footer after:
After - footer shows 'las autoras'

@joelnitta
Copy link
Contributor

@ErinBecker please see ErinBecker#1 with JA translation

@ErinBecker
Copy link
Contributor Author

The build check for Windows 4.1 is failing with the following output:

  Running 'testthat.R' [239s]
 ERROR
Running the tests in 'tests/testthat.R' failed.
Last 13 lines of output:
  -- Failure ('test-move_episode.R:15:3'): all episodes are present in the config file --
  `eps` (`actual`) and fs::path_file(get_sources(res, "episodes")) (`expected`) don't have the same values.
  * Only in `actual`: "data", "fig", "files"
  
  
  [ FAIL 9 | WARN 2 | SKIP 66 | PASS 929 ]
  Error: Test failures
  i removing 'sandpaper-local' ('D:/a/_temp/Rtmp0wmdmM/working_dir/RtmpO68jjj/REMOTE-15cc59a5ed2')
  x Error trying to remove remote
  [EPERM] Failed to remove
  'D:/a/_temp/Rtmp0wmdmM/working_dir/RtmpO68jjj/REMOTE-15cc59a5ed2/objects/pack/pack-55abd0f3f2d77afd2575a4b80c4e649ef9696955.idx':
  operation not permitted
  i 'D:/a/_temp/Rtmp0wmdmM/working_dir/RtmpO68jjj/file15cc54f25a92/lesson-example' successfully removed
  i local remote could not be removed
  Execution halted
* checking for unstated dependencies in vignettes ... OK
* checking package vignettes in 'inst/doc' ... OK
* checking re-building of vignette outputs ... OK
* checking for non-standard things in the check directory ... OK
* checking for detritus in the temp directory ... OK
* DONE
Status: 1 ERROR, 3 NOTEs

There are also failed checks starting at line 625

Need to do more testing to understand these errors.

@froggleston froggleston merged commit 02a2dc4 into carpentries:main May 7, 2024
12 checks passed
@froggleston
Copy link
Contributor

These errors were spurious and specific to that build. Rerunning seemed to work, so merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing translation strings
3 participants