Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create French translations #578

Merged
merged 5 commits into from May 8, 2024
Merged

Conversation

Bisaloo
Copy link
Contributor

@Bisaloo Bisaloo commented Apr 5, 2024

No description provided.

@froggleston
Copy link
Contributor

This looks great! To bring this in line with the (very) recent update to the search button, could you edit the "search button" entry to reflect the new search button string "Search the All In One page" and the corresponding translation? An example is here: 415d3b9#diff-a52bd8caba357e9e7cd1adf67b7de52a2bb5b51767d9218bf066aa555b34abb3R79

Thank you for this great contribution!

@froggleston
Copy link
Contributor

Hi again @Bisaloo - we've made another small update to the core string and corresponding translation for "the authors" found in lesson footers, as per this merged PR: #582

Please could you update your translation as before to take this into account and I'll merge it in! Thank you!

@froggleston froggleston merged commit 96580d8 into carpentries:main May 8, 2024
12 checks passed
@Bisaloo Bisaloo deleted the fr-translation branch May 8, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants