Add spoiler class of fenced div #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobyhodges
commented
Aug 21, 2023
zkamvar
reviewed
Aug 21, 2023
There was a problem hiding this comment.
This is a good start and I really appreciate your digging into lua to get this working!
I've left a couple of comments that will clean up the code a bit.
It would be good to add an example in the tests/testthat/examples/ex.md, which is tested in tests/testthat/test-render_html.R using snapshot testing.
The tests will fail when you add it, but I will fenagle the tests to be better at filtering (there is a weird thing with pandoc where the attributes are added in a random order, which messes up the tests, so I have to manually clean them up in the test).
Co-authored-by: Zhian N. Kamvar <zkamvar@gmail.com>
|
After updating varnish, I see this, so I think we can declare that it works!
|
|
Excellent, thanks @zkamvar 🙌 |
This was referenced Aug 30, 2023
|
Thank you Toby! |
This was referenced Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
spoilerclass of accordion fenced div, which could be used instead of "floating"solutionblocks where the user wants to give the option to view/hide additional detail.Styling for this class would be added by carpentries/varnish#92