width and height methods for image processing #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Specs? |
|
Specs added . |
bensie
added a commit
that referenced
this pull request
Jul 8, 2014
width and height methods for image processing
mehlah
pushed a commit
to mehlah/carrierwave
that referenced
this pull request
Dec 29, 2015
This method doesn't need to be part of the public API. It's used by the new public `#width` and `#height` methods (introduced by carrierwaveuploader#1405). Minor tweaks to comments.
mehlah
pushed a commit
to mehlah/carrierwave
that referenced
this pull request
Dec 29, 2015
This keeps the symmetry with MiniMagick processor where `#width` and `#height` methods has been introduced by carrierwaveuploader#1405.
mehlah
pushed a commit
to mehlah/carrierwave
that referenced
this pull request
Dec 29, 2015
This method doesn't need to be part of the public API. It's used by the new public `#width` and `#height` methods (introduced by carrierwaveuploader#1405). This commit also fixes a typo in the method name and tweaks the comments.
This was referenced Dec 29, 2015
mehlah
pushed a commit
to mehlah/carrierwave
that referenced
this pull request
Dec 30, 2015
This keeps the symmetry with MiniMagick processor where `#width` and `#height` methods has been introduced by carrierwaveuploader#1405.
mynock
pushed a commit
to mynock/carrierwave
that referenced
this pull request
Aug 9, 2016
This method doesn't need to be part of the public API. It's used by the new public `#width` and `#height` methods (introduced by carrierwaveuploader#1405). This commit also fixes a typo in the method name and tweaks the comments.
mynock
pushed a commit
to mynock/carrierwave
that referenced
this pull request
Aug 9, 2016
This keeps the symmetry with MiniMagick processor where `#width` and `#height` methods has been introduced by carrierwaveuploader#1405.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
Gives the width and height of the uploaded image , useful for AR validation etc .