Make CarrierWave::MiniMagick#mini_magic_image private
#1804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method doesn't need to be part of the public API. It's used by the new public `#width` and `#height` methods (introduced by carrierwaveuploader#1405). This commit also fixes a typo in the method name and tweaks the comments.
|
Thanks @mehlah. I'm happy with this change. While it represents a breaking change, we're going into a major version release, so that's acceptable. I'm going to restart the build on CI, and if it passes then I'll get this merged. |
thomasfedb
added a commit
that referenced
this pull request
Dec 30, 2015
Make `CarrierWave::MiniMagick#mini_magic_image` private
mehlah
pushed a commit
to mehlah/carrierwave
that referenced
this pull request
Dec 30, 2015
This was introduced by a bad merge of carrierwaveuploader#1804 and carrierwaveuploader#1806 which both were based on master and added the `private` keyword for two different methods.
mynock
pushed a commit
to mynock/carrierwave
that referenced
this pull request
Aug 9, 2016
This was introduced by a bad merge of carrierwaveuploader#1804 and carrierwaveuploader#1806 which both were based on master and added the `private` keyword for two different methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think
CarrierWave::MiniMagick#mini_magic_imagemethod doesn't need to be part of the public API, at least to keep a symmetry between MiniMagick and RMagick processors (more at #1805).This method is used by the new public
#widthand#heightmethods (introduced by #1405).This commit also fixes a typo in the method name (magick instead of magic).
Any thoughts?