-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Fog Loading #1620
Improve Fog Loading #1620
Conversation
Awesome, thanks! |
Wow. Thank you for the fast support. ❤️ |
@bensie When will be a new release including this changes? |
@plribeiro3000 Nice! :) Thanks |
@bensie @eavgerinos Did i forgot something in here? |
I was having the same issue, and this fixed it for the most part. One note: Once I got that switched, this seems to work great for me. Probably worth updating the README. |
@thejbsmith Fixed :) |
This PR is an attempt to create an easy support for both providers within
fog
and the ones that were already extracted.Instead of rely on constant definition to load
fog
support, now it depends on a configuration.If
fog_provider
is not definedcarrierwave
will try to loadfog
completely. If the user has onlyfog-aws
on its Gemfile it will fail.The use won't need to require any
fog
specifics beforecarrierwave
anymore becausecarrierwave
will do that now.The optimized loading of fog is not necessary if the user is using an extracted provider and
google
was extracted so i did some changes onREADME
reflecting this.Let me know if i need to change something else or something is wrong.