[Fix #1594] Reset remove attribute after invoking remove_#{image} #1668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure this should go in this method. Maybe it's a responsibility of What do you think? @bensie @plribeiro3000 |
|
@eavgerinos I'm not sure either but this change its kind of bad. The result of the method will be false when it should reflect if the result of the operation was successful or not. Maybe we could leave the code as it is if we just pull the |
avgerin0s
force-pushed
the
fix-1594
branch
2 times, most recently
from
eff9ff0
to
2659e4b
Compare
|
@plribeiro3000 Fixed. :) |
|
👍 |
|
@eavgerinos If is not to ask too much maybe we could have a test to ensure this won´t break in the future? or at least some documentation? |
This fixes the behaviour of write_#{column}_identifier in order to
accept re-uploading a file after the previous one was removed from
the same Uploader's instance.
|
@plribeiro3000 Added :) |
|
Awesome @eavgerinos . You are the best! 👍 |
avgerin0s
added a commit
that referenced
this pull request
Sep 11, 2015
[Fix #1594] Reset remove attribute after invoking remove_#{image}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the behaviour of write_#{column}_identifier in order to
accept re-uploading a file after the previous one was removed from
the same Uploader's instance.