Remove CarrierWave::MimeTypes processor module
#1813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm happy to remove this processor module. It's clearly deprecated, and offers very little. |
|
I'd welcome a PR that removed the need for |
mehlah
force-pushed
the
remove-mimetypes-module
branch
from
b80b8a3
to
2fc9ed3
Compare
|
@thomasfedb thanks for your feedback. I'll work on removing MagicMime then 👍 |
Since carrierwaveuploader#1245 (*), CarrierWave::MimeTypes module is redundant as `mime-types` gem is a runtime dependency now, and `SanitizedFile` gets it's content_type using it. The module was deprecated since 0.10 and warned developers when used it. (*) I discovered this when tried to fix specs marked as pending. I looked at commits history and PRs to understand what happened. It started with carrierwaveuploader#372 that added `CarrierWave::MimeTypes` processor (Jun 2011), then carrierwaveuploader#1216 and carrierwaveuploader#1245 that made `mime-types` a runtime dependency and deprecated `CarrierWave::MimeTypes` module (2013), and finally carrierwaveuploader#1584 `CarrierWave::MagicMimeTypes` (2015)
mehlah
force-pushed
the
remove-mimetypes-module
branch
from
2fc9ed3
to
947eee5
Compare
mehlah
pushed a commit
to mehlah/carrierwave
that referenced
this pull request
Jan 1, 2016
See carrierwaveuploader#1813 for background.
mehlah
pushed a commit
to mehlah/carrierwave
that referenced
this pull request
Jan 1, 2016
Before this, CarrierWave was relying on mime-types or ruby-filemagic gems to get/set the content type of a file in an inconsistent way. After making mime-types a runtime dependency for CW, `CarrierWave::MimeTypes` has been dropped (carrierwaveuploader#1813 for details), and `CarrierWave::MagicMimeTypes` as well. White/blacklisting content types feature was relying only on ruby-filemagic to read the content type of a file. It was optional and required mixing a module to the uploader. This commit remove this dependency by using the already available content type (thanks to `Mime::Types`). This let us drop any dependency on ruby-filemagic in CarrierWave. It makes JRuby support better as ruby-filemagic is unsupported on JRuby due to the C extension.
mehlah
pushed a commit
to mehlah/carrierwave
that referenced
this pull request
Jan 1, 2016
Before this, CarrierWave was relying on mime-types or ruby-filemagic gems to get/set the content type of a file in an inconsistent way. After making mime-types a runtime dependency for CW, `CarrierWave::MimeTypes` has been dropped (carrierwaveuploader#1813 for details), and `CarrierWave::MagicMimeTypes` as well. White/blacklisting content types feature (introduced by carrierwaveuploader#1596) was relying only on ruby-filemagic to read the content type of a file. It was optional and required mixing a module to the uploader. This commit removes this dependency by using the already available content type (thanks to `Mime::Types`). This let us drop any dependency on ruby-filemagic in CarrierWave. It makes JRuby support better as ruby-filemagic is unsupported on JRuby due to the C extension.
|
@thomasfedb I removed the need of |
mehlah
pushed a commit
to mehlah/carrierwave
that referenced
this pull request
Jan 2, 2016
Before this, CarrierWave was relying on mime-types or ruby-filemagic gems to get/set the content type of a file in an inconsistent way. After making mime-types a runtime dependency for CW, `CarrierWave::MimeTypes` has been dropped (carrierwaveuploader#1813 for details), and `CarrierWave::MagicMimeTypes` as well. White/blacklisting content types feature (introduced by carrierwaveuploader#1596) was relying only on ruby-filemagic to read the content type of a file. It was optional and required mixing a module to the uploader. This commit removes this dependency by using the already available content type (thanks to `Mime::Types`). This let us drop any dependency on ruby-filemagic in CarrierWave. It makes JRuby support better as ruby-filemagic is unsupported on JRuby due to the C extension.
thomasfedb
added a commit
that referenced
this pull request
Jan 2, 2016
Remove depreciated CarrierWave::MimeTypes processor
mehlah
pushed a commit
to mehlah/carrierwave
that referenced
this pull request
Jan 2, 2016
See carrierwaveuploader#1813 for background.
mehlah
pushed a commit
to mehlah/carrierwave
that referenced
this pull request
Jan 2, 2016
Before this, CarrierWave was relying on mime-types or ruby-filemagic gems to get/set the content type of a file in an inconsistent way. After making mime-types a runtime dependency for CW, `CarrierWave::MimeTypes` has been dropped (carrierwaveuploader#1813 for details), and `CarrierWave::MagicMimeTypes` as well. White/blacklisting content types feature (introduced by carrierwaveuploader#1596) was relying only on ruby-filemagic to read the content type of a file. It was optional and required mixing a module to the uploader. This commit removes this dependency by using the already available content type (thanks to `Mime::Types`). This let us drop any dependency on ruby-filemagic in CarrierWave. It makes JRuby support better as ruby-filemagic is unsupported on JRuby due to the C extension.
mehlah
pushed a commit
to mehlah/carrierwave
that referenced
this pull request
Jan 2, 2016
See carrierwaveuploader#1813 for background.
mehlah
pushed a commit
to mehlah/carrierwave
that referenced
this pull request
Jan 2, 2016
Before this, CarrierWave was relying on mime-types or ruby-filemagic gems to get/set the content type of a file in an inconsistent way. After making mime-types a runtime dependency for CW, `CarrierWave::MimeTypes` has been dropped (carrierwaveuploader#1813 for details), and `CarrierWave::MagicMimeTypes` as well. White/blacklisting content types feature (introduced by carrierwaveuploader#1596) was relying only on ruby-filemagic to read the content type of a file. It was optional and required mixing a module to the uploader. This commit removes this dependency by using the already available content type (thanks to `Mime::Types`). This let us drop any dependency on ruby-filemagic in CarrierWave. It makes JRuby support better as ruby-filemagic is unsupported on JRuby due to the C extension.
mehlah
pushed a commit
to mehlah/carrierwave
that referenced
this pull request
Jan 2, 2016
Before this, CarrierWave was relying on mime-types or ruby-filemagic gems to get/set the content type of a file in an inconsistent way. After making mime-types a runtime dependency for CW, `CarrierWave::MimeTypes` has been dropped (carrierwaveuploader#1813 for details), and `CarrierWave::MagicMimeTypes` as well. White/blacklisting content types feature (introduced by carrierwaveuploader#1596) was relying only on ruby-filemagic to read the content type of a file. It was optional and required mixing a module to the uploader. This commit removes this dependency by using the already available content type (thanks to `Mime::Types`). This let us drop any dependency on ruby-filemagic in CarrierWave. It makes JRuby support better as ruby-filemagic is unsupported on JRuby due to the C extension.
mehlah
pushed a commit
to mehlah/carrierwave
that referenced
this pull request
Jan 2, 2016
See carrierwaveuploader#1813 for background.
mehlah
pushed a commit
to mehlah/carrierwave
that referenced
this pull request
Jan 2, 2016
Before this, CarrierWave was relying on mime-types or ruby-filemagic gems to get/set the content type of a file in an inconsistent way. After making mime-types a runtime dependency for CW, `CarrierWave::MimeTypes` has been dropped (carrierwaveuploader#1813 for details), and `CarrierWave::MagicMimeTypes` as well. White/blacklisting content types feature (introduced by carrierwaveuploader#1596) was relying only on ruby-filemagic to read the content type of a file. It was optional and required mixing a module to the uploader. This commit removes this dependency by using the already available content type (thanks to `Mime::Types`). This let us drop any dependency on ruby-filemagic in CarrierWave. It makes JRuby support better as ruby-filemagic is unsupported on JRuby due to the C extension.
mynock
pushed a commit
to mynock/carrierwave
that referenced
this pull request
Aug 9, 2016
See carrierwaveuploader#1813 for background.
mynock
pushed a commit
to mynock/carrierwave
that referenced
this pull request
Aug 9, 2016
Before this, CarrierWave was relying on mime-types or ruby-filemagic gems to get/set the content type of a file in an inconsistent way. After making mime-types a runtime dependency for CW, `CarrierWave::MimeTypes` has been dropped (carrierwaveuploader#1813 for details), and `CarrierWave::MagicMimeTypes` as well. White/blacklisting content types feature (introduced by carrierwaveuploader#1596) was relying only on ruby-filemagic to read the content type of a file. It was optional and required mixing a module to the uploader. This commit removes this dependency by using the already available content type (thanks to `Mime::Types`). This let us drop any dependency on ruby-filemagic in CarrierWave. It makes JRuby support better as ruby-filemagic is unsupported on JRuby due to the C extension.
|
Just wanted to thank @mehlah for going through the extra effort of researching and documenting the history of |
|
Thanks @earksiinni for the kind words ;) |
bagedevimo
added a commit
to NZOI/nztrain
that referenced
this pull request
Feb 27, 2023
According the README and changelog these are now optional - the changelog is automatically inferred. It's hard to reference specific commits, but this MR removed it [1]. [1] carrierwaveuploader/carrierwave#1813
tom93
added a commit
to NZOI/nztrain
that referenced
this pull request
Feb 27, 2023
The method has been removed, and according to the README and changelog it is longer necessary to set the content type manually - it is automatically inferred. It's hard to reference specific commits, but this MR removed it: [1]. [1] carrierwaveuploader/carrierwave#1813 Co-authored-by: Tom Levy <tomlevy93@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #1245 (*), CarrierWave::MimeTypes module is redundant as
mime-typesgem is a runtime dependency now, andSanitizedFilegets it's content_type using it.The module was deprecated since 0.10 and warned developers when used it.
What do you think about removing MagicMimeTypes processor module too?
I can't see any valid reason to keep it around.
A related side note: CarrierWave rely on ruby-filemagic gem (
MagicMime) to validates the content type of a file against a white/blacklist.I think we should use mime-types (
Mime::Types) for this as it's a runtime dependency, and it's consistent with what it's used bySanitizedFileto set a content type.Otherwise, we could use
MagicMimeeverywhere as a runtime dependency instead ofMime::Types, but this kills JRuby support.(*) I discovered this when tried to fix specs marked as pending. I looked at commits history and PRs to understand what happened.
It started with #372 that added
CarrierWave::MimeTypesprocessor (Jun 2011), then #1216 and #1245 that mademime-typesa runtime dependency and deprecatedCarrierWave::MimeTypesmodule (2013), and finally #1584CarrierWave::MagicMimeTypes(2015)