Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CarrierWave::MimeTypes processor module #1813

Merged

Commits on Jan 1, 2016

  1. Remove CarrierWave::MimeTypes processor module

    Since carrierwaveuploader#1245 (*), CarrierWave::MimeTypes module is redundant as
    `mime-types` gem is a runtime dependency now, and `SanitizedFile` gets
    it's content_type using it.
    The module was deprecated since 0.10 and warned developers when used it.
    
    (*) I discovered this when tried to fix specs marked as pending. I
    looked at commits history and PRs to understand what happened.
    It started with carrierwaveuploader#372 that added `CarrierWave::MimeTypes`  processor (Jun
    2011), then carrierwaveuploader#1216 and carrierwaveuploader#1245 that made `mime-types` a runtime dependency
    and deprecated `CarrierWave::MimeTypes` module (2013), and finally carrierwaveuploader#1584
    `CarrierWave::MagicMimeTypes` (2015)
    Mehdi Lahmam committed Jan 1, 2016
    Configuration menu
    Copy the full SHA
    947eee5 View commit details
    Browse the repository at this point in the history