Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warning if #filename is safeguarded as in the pre-3.x style #2718

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

mshibuya
Copy link
Member

Context: #2708 (comment)

I'm not totally sure that this is side-effect-free (there can be a legitimate case for #filename not to return value?) , but at least it can be helpful to some people.
I want to hear your opinion.
@y-yagi @RachalCassity @rajyan @ryan-mcneil

Closes #2708, Refs. #2659

@rajyan
Copy link
Contributor

rajyan commented Jan 19, 2024

What I'm not sure is, whether there are other usage for original_filename. The change itself seems like it could be beneficial for the 3.x upgrade.

@mshibuya mshibuya force-pushed the warn-if-filename-is-safeguarded branch from 257fc34 to 127ccd5 Compare January 29, 2024 09:41
@mshibuya mshibuya force-pushed the warn-if-filename-is-safeguarded branch from 127ccd5 to 21e346e Compare January 29, 2024 10:20
@mshibuya mshibuya merged commit 8b33235 into master Feb 4, 2024
22 of 24 checks passed
@mshibuya mshibuya deleted the warn-if-filename-is-safeguarded branch February 4, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The code depends on @original_filename doesn't work since v3.0.4
2 participants