Escape plusses for the download! #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there's a plus in, say, an S3 signed request generated by fog, and it gets unescaped, you'll get a 403 when you try and hit it.
bensie
added a commit
that referenced
this pull request
Apr 4, 2012
Escape plusses for the download!
|
Not a fan of the endless chaining of gsub calls, but hey, what's one more? Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there's a plus in, say, an S3 signed request generated by fog, and it gets unescaped, you'll get a 403 when you try and hit it.
I was getting similar symptoms to #294 whenever my signed requests to S3 had a plus in them - this fixes that. I'd like to make sure it doesn't break urls for folks if there's a plus in the non-params.
Another possibility (and one that I'm actually doing on my side of things) is to get smarter about how params are handled in a remote_url. I'm having to explicitly strip off params in my fork of carrierwave_direct, otherwise my generated versions have the params included in their name. This is on my list of things to investigate post-launch, whether this is cw-direct or cw's responsibility.
Thanks!