Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(qa): create campaign #524

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

feat(qa): create campaign #524

wants to merge 6 commits into from

Conversation

MilanVojnovic95
Copy link
Collaborator

@MilanVojnovic95 MilanVojnovic95 commented Nov 23, 2023 •
edited

  • create campaign test
  • added additional data
  • added selectors for authorization modal
  • installed faker library for data
  • rewrote initial connect wallet test

Note: test will currently not work on stage since there are some selectors missing

MilanVojnovic95 and others added 2 commits November 22, 2023 16:52
@MilanVojnovic95 @guerrap
feat: initial smoke test (#511)
8564368 
* feat: smoke test [WIP]

* feat(qa): smoke test [WIP]

* feat(qa): added more steps, selectors [WIP]

* feat(qa): added additional assertions for smoke

* feat(qa): fixing comments

* feat(qa): edit script

* fix(frontend): add yarn prefix to script

---------

Co-authored-by: Paolo Guerra <pg.guerrap@proton.me>
@MilanVojnovic95
feat(qa): create campaign [WIP]
35cfc3e
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 23, 2023 •
edited

⚠️ No Changeset found

Latest commit: 10d1089

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 23, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
host-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2023 10:31pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2023 10:31pm

@MilanVojnovic95 MilanVojnovic95 marked this pull request as ready for review December 5, 2023 00:04
@MilanVojnovic95
Copy link
Collaborator Author

@guerrap As mentioned there are some selectors missing, which are blocking test development

  • on Rewards step the selection of reward token
  • total value locked option
  • protocol options
  • expiry date
  • go to campaign button

I've left empty vairables on createCampaingPage.ts as well.

@MilanVojnovic95 MilanVojnovic95 changed the title feat(qa): create campaign [WIP] feat(qa): create campaign Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guerrap guerrap Awaiting requested review from guerrap

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@MilanVojnovic95