API Refactor #38
Merged
API Refactor #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 28 commits
June 23, 2014 15:29
- remove nodejitsu deployer, not useful - rewrite s3 adapter to fit new spec. not yet tested - get .configure tests passing
- add a 'nowhere' deployer, which accepts nothing as config and does nothing. very useful stuff here. - write basic tests for deploy api call - methods that return promises do not throw anymore, only return rejections - add a bit more protection for deployers with no config - some other small fixes here and there
|
Changes Unknown when pulling 8e68ee0 on refactor into * on master*. |
added 4 commits
July 21, 2014 18:54
- not entirely working correctly yet with nesting - travis issue makes tests not pass on travis - but the majority of the logic is there, whoo!
|
Changes Unknown when pulling 7f055fe on refactor into * on master*. |
added 9 commits
July 21, 2014 18:56
|
Changes Unknown when pulling 4856a85 on refactor into * on master*. |
|
Changes Unknown when pulling 81ad97f on refactor into * on master*. |
|
Changes Unknown when pulling 8c0275d on refactor into * on master*. |
added 3 commits
July 22, 2014 16:13
|
:thugs_tear: |
|
Oh man, that's a big deal. Not many of those are shed! 🍉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some small adjustments to the API to make everything smoother.
Shipas a class, makes persisting state easier, less repetitionThen, complete rewrites of the heroku and github pages deployers to make them work smoothly with the new API, and eliminate external command line dependencies.