Modernizing library

[hazendaz]

• Fixed Junit
  • Use only non-deprecated Junit imports
  • added .5 delta to satisfy latest junit.
• Maven Note
  • Maven build fails when test\non-default\output\dir\absolute-path is
    missing. Added temporary text file to mark issue.
• Interface Cleanup
  • Removed public from methods in interface as they are implied by the
    context
• Removed unnecessary location defined by import
  • java.security already an import. No conflicts exist, so removed it from
    MessageDigest as indicated per PMD.
• Updated code to use lasest ant library
• POM Cleanup
  • Added versions plugin to see what is out of date.
  • Updated all out of date plugins
  • Fixed some spelling mistakes
  • Override PMD with latest.
  • Updated to java 6 build
  • Updated dependencies to latest
  • Overall build time changes by very little as a result of these changes.
• Updated code to use latest guava library
• Switch localized StringBuffer to StringBuilder
• Replace fest-assert with assertj
• Replace commons-lang with guava

[aadrian]

+1

[hazendaz]

I'm willing to rework the commit line on this once this is reviewed assuming it will be accepted. This brings it completely up to date as of 1/4/2015 :)

[hazendaz]

Any status on this PR?

[hazendaz]

Hi again! I rebased so this is clean again as well as completely reworked the commit lines so it is easy to follow. @stanislawosinski can you take a look at this? We have been using this in a production setting for a long time now without any issues. I would like to get this on the master if possible. If you need smaller PR requests I can do that as well. Thanks.

[stanislawosinski]

Thanks for the PR! I see that the build passed (http://builds.carrotsearch.com/browse/SMARTSPRITES-SOFTWARE-15).

[hazendaz]

You're welcome and thanks for merging.

--- Original Message ---

From: "Stanisław Osiński" notifications@github.com
Sent: May 21, 2015 3:15 AM
To: "carrotsearch/smartsprites" smartsprites@noreply.github.com
Cc: "Jeremy Landis" jeremylandis@hotmail.com
Subject: Re: [smartsprites] Modernizing library (#10)

Thanks for the PR! I see that the build passed (http://builds.carrotsearch.com/browse/SMARTSPRITES-SOFTWARE-15).

---

Reply to this email directly or view it on GitHub:
#10 (comment)