-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify slide out time, TypeScript typings #20
Conversation
Sorry for the late reply and thanks for the PR! slideOutTime, linting and typescript are all good. Great job! For the style part, I think there are too many customization props in this way. It will be cleaner and more intuitive if we let user pass their custom components instead of styling props. Let me know what you think. |
@carsonwah Yea that sounds good to me. How granular were you thinking? e.g. optional |
@danielholmes I think we can take the approach from another PR #17. It takes a just a custom component that goes inside the |
@carsonwah I've removed the custom styling/rendering from this PR - I didn't realise there was another open, so I'll leave that task to #17 |
@danielholmes Merged. Thanks so much for the contribution. I will release a new version asap, maybe together with #17. |
Apologies for the multiple updates in one - I'll be happy to pick them apart individually if you're only interested in some. Updates here include:
slideOutTime
to theshow
methodprop
Let me know your thoughts and if you want any modifications.