Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #85 Add rule no-subscribe-callbacks #86

Merged
merged 1 commit into from
Oct 26, 2021
Merged

feat: #85 Add rule no-subscribe-callbacks #86

merged 1 commit into from
Oct 26, 2021

Conversation

artfulsage
Copy link
Contributor

No description provided.

@artfulsage
Copy link
Contributor Author

@cartant check it please

@cartant
Copy link
Owner

cartant commented Oct 25, 2021

Sorry, I've been distracted by other things. I'll get this reviewed and merged sometime today.

Copy link
Owner

@cartant cartant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

docs/rules/no-subscribe-callbacks.md Show resolved Hide resolved
@cartant cartant merged commit ea36a6d into cartant:main Oct 26, 2021
@cartant
Copy link
Owner

cartant commented Oct 26, 2021

4.0.1 should be published now and should include this rule. Although, as mentioned in the review, after seeing your use of 'handlers' in the docs, I've renamed it to no-subscribe-handlers.

@artfulsage artfulsage deleted the add-rule-no-subscribe-callbacks branch October 26, 2021 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants